Fix, test, and enable custom domain tags. #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
261d5c9 to
ba88a2f
Compare
Kubuxu
reviewed
Oct 19, 2021
Kubuxu
reviewed
Oct 19, 2021
ba88a2f to
9e3bf89
Compare
|
Looks good to me |
9e3bf89 to
00a87a7
Compare
dignifiedquire
approved these changes
Oct 21, 2021
5 tasks
Kubuxu
reviewed
Oct 21, 2021
| HashType::Encryption => with_strength(pow2::<F>(32)), | ||
| // identifier * 2^40 | ||
| // identifier * 2^(40 + strength) -- where standard strength is 0. |
There was a problem hiding this comment.
The formula is a bit wrong I think,
it should be identifier * 2^40 + strength * 2^32.
There was a problem hiding this comment.
Yes, I think that's correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fill in the blanks of the custom domain tag implementation, and enable it — with support for 256 unique tags. Although it would be possible to add more, I wanted to be conservative, and this should be plenty.
The way the tag space is divided up and
Standard/Strengthenedvariants are supported makes this already a little crowded and confusing. Let's minimize the extent to which we paint our future selves into a corner by annexing only what we need for now.