Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor clang-tidy fixes #75

Merged
merged 2 commits into from
Apr 7, 2022
Merged

Conversation

igrr
Copy link
Contributor

@igrr igrr commented Apr 5, 2022

Hi @tomghuang, thank you for maintaining this excellent library!

This small PR fixes two issues reported in esp-idf project by clang-tidy:

  1. String literals were assigned to char* variables instead of const char*. The fix looks pretty straightforward.
  2. Function argument name in declaration and definition of arg_end function was different (maxerrors vs maxcount). I opted to change the name in the header file for smaller number of changes. Let me know if you prefer it the other way around.

@tomghuang tomghuang merged commit 6f0e40b into argtable:master Apr 7, 2022
@tomghuang
Copy link
Contributor

Hi @igrr , thank you very much for this PR, which really helps to improve the quality of the project. I will try to add -Wwrite-strings to the CMake script. Thanks.

@igrr igrr deleted the minor_clang_tidy_fixes branch April 7, 2022 17:10
@igrr
Copy link
Contributor Author

igrr commented Apr 7, 2022

Thanks for the quick review and merge!

By the way, if you still have interest in #70 I can open a PR for it.

@tomghuang
Copy link
Contributor

Hi @igrr ,

Yes, I'm very interested in using tools to scan security vulnerabilities in the code base. If you can provide help on #70, that would be great! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants