Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme #191

Merged
merged 1 commit into from
Feb 4, 2019
Merged

Update readme #191

merged 1 commit into from
Feb 4, 2019

Conversation

imjared
Copy link
Contributor

@imjared imjared commented Jan 26, 2019

Summary

Just a quick update to docs after receiving the following message:

Option "setupTestFrameworkScriptFile" was replaced by configuration "setupFilesAfterEnv", which supports multiple paths.
https://jestjs.io/docs/configuration.html

Test plan

Change to the new API and run jest. Should work as expected.

>   Option "setupTestFrameworkScriptFile" was replaced by configuration "setupFilesAfterEnv", which supports multiple paths.
https://jestjs.io/docs/configuration.html
@imjared imjared changed the title Update jest api Update readme Jan 26, 2019
@gregberge
Copy link
Member

gregberge commented Jan 28, 2019

Thanks for catching it, I think we have to change it in the preset too. But we have to be careful to not break compatibility with old Jest versions.

@gregberge gregberge merged commit e64d9be into argos-ci:master Feb 4, 2019
@gregberge
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants