fix: Default to insecure mode when no certs are present

[simster7]

Fixes #5466

Signed-off-by: Simon Behar simbeh7@gmail.com

Checklist:

• My organization is added to USERS.md.

[codecov]

Codecov Report

Merging #5511 (2f56c8c) into master (b8af341) will increase coverage by 0.25%.
The diff coverage is 14.28%.

❗ Current head 2f56c8c differs from pull request most recent head ea74beb. Consider uploading reports for the commit ea74beb to get more accurate results

@@            Coverage Diff             @@
##           master    #5511      +/-   ##
==========================================
+ Coverage   46.69%   46.95%   +0.25%     
==========================================
  Files         240      240              
  Lines       15004    15011       +7     
==========================================
+ Hits         7006     7048      +42     
+ Misses       7102     7066      -36     
- Partials      896      897       +1     

Impacted Files	Coverage Δ
cmd/argo/commands/server.go	34.51% <14.28%> (+34.51%)	⬆️
workflow/metrics/server.go	12.50% <0.00%> (-4.17%)	⬇️
cmd/argoexec/commands/emissary.go	48.43% <0.00%> (-1.57%)	⬇️
workflow/controller/operator.go	70.96% <0.00%> (+0.27%)	⬆️
cmd/argo/commands/get.go	56.66% <0.00%> (+0.66%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8af341...ea74beb. Read the comment docs.

[alexec]

I don’t think understand why so many users broken. Are you sure v3 works with —secure=true? Why was it breaking? These files are on the image. Could it be we need to backport of fix something else?

[simster7]

I don’t think understand why so many users broken. Are you sure v3 works with —secure=true? Why was it breaking? These files are on the image. Could it be we need to backport of fix something else?

I believe a lot of users download the binary from GitHub (not a Docker image) and run argo server from their own command lines. In those cases, the self-signed certs are not available. Since this used to work before, many users are surprised when it suddenly does not.

[simster7]

@alexec Addressed per your comments in #5466 (comment)

[alexec]

Wouldn’t it be easier just to do io.Stat on line 158?

[simster7]

Wouldn’t it be easier just to do io.Stat on line 158?

Sorry @alexec, could I ask you to clarify what you mean? It's not clear which line of code do you mean by "line 158" based on the numbering from this PR's file changes

[alexec]

Wouldn’t it be easier just to do io.Stat on line 158?

Sorry @alexec, could I ask you to clarify what you mean? It's not clear which line of code do you mean by "line 158" based on the numbering from this PR's file changes

It is like 158 before modification.

Something like:

_, err := os.Stat("argo-server.crt")
command.Flags().BoolVarP(&secure, "secure", "e", !os.IsNotFoundErr(err), "Whether or not we should listen on TLS.")

[simster7]

@alexec Clever, I like that. Changed

[alexec]

nice work!