Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unused work queue in Cron controller #5461

Merged
merged 1 commit into from
Mar 20, 2021
Merged

chore: Remove unused work queue in Cron controller #5461

merged 1 commit into from
Mar 20, 2021

Conversation

terrytangyuan
Copy link
Member

Signed-off-by: terrytangyuan terrytangyuan@gmail.com

Checklist:

Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #5461 (bf4fc60) into master (3b129a8) will increase coverage by 0.16%.
The diff coverage is 32.29%.

❗ Current head bf4fc60 differs from pull request most recent head 5aa163c. Consider uploading reports for the commit 5aa163c to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5461      +/-   ##
==========================================
+ Coverage   16.30%   16.47%   +0.16%     
==========================================
  Files         243      243              
  Lines       43675    43767      +92     
==========================================
+ Hits         7121     7209      +88     
+ Misses      35582    35575       -7     
- Partials      972      983      +11     
Impacted Files Coverage Δ
pkg/apis/workflow/v1alpha1/generated.pb.go 0.51% <0.00%> (-0.01%) ⬇️
pkg/apis/workflow/v1alpha1/openapi_generated.go 0.00% <0.00%> (ø)
...kg/apis/workflow/v1alpha1/zz_generated.deepcopy.go 7.50% <0.00%> (+4.01%) ⬆️
workflow/cron/controller.go 0.00% <ø> (ø)
workflow/controller/operator.go 70.27% <47.36%> (-0.52%) ⬇️
pkg/apis/workflow/v1alpha1/workflow_types.go 45.52% <100.00%> (+1.98%) ⬆️
cmd/argo/commands/get.go 56.00% <0.00%> (-1.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b129a8...5aa163c. Read the comment docs.

@alexec alexec merged commit d10696d into argoproj:master Mar 20, 2021
@terrytangyuan terrytangyuan deleted the chore-rm-unused-cron branch March 20, 2021 04:25
@simster7 simster7 mentioned this pull request Mar 22, 2021
34 tasks
@simster7 simster7 mentioned this pull request Mar 29, 2021
77 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants