Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): Fixed wrong error message #5390

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

dinever
Copy link
Member

@dinever dinever commented Mar 13, 2021

Signed-off-by: Peixuan Ding dingpeixuan911@gmail.com

When submitting a WF with an invalid PodSpecPatch:

apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  generateName: pod-spec-patch-
spec:
  entrypoint: whalesay
  templates:
  - name: whalesay
    podSpecPatch: '{"container"}'
    container:
      image: docker/whalesay:latest
      command: [cowsay]
      args: ["hello world"]

Screen Shot 2021-03-12 at 11 11 11 PM

The error message incorrectly states Fail to marshal the Pod spec. I believe this is a mistake. This PR fixes it.

Also changed a bunch of Fail to to Failed to in order to be more consistent with other error messages.

Signed-off-by: Peixuan Ding <dingpeixuan911@gmail.com>
@dinever dinever force-pushed the fix-wrong-error-message branch from c89f413 to f4b05bb Compare March 13, 2021 04:40
@simster7 simster7 merged commit 1ec7ac0 into argoproj:master Mar 15, 2021
@dinever dinever deleted the fix-wrong-error-message branch March 15, 2021 03:14
@simster7 simster7 mentioned this pull request Mar 15, 2021
27 tasks
@simster7 simster7 mentioned this pull request Mar 29, 2021
77 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants