Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Github actions refactor #5280

Merged
merged 16 commits into from
Mar 8, 2021
Merged

ci: Github actions refactor #5280

merged 16 commits into from
Mar 8, 2021

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Mar 3, 2021

Make builds faster and more robust.

@alexec alexec force-pushed the fast branch 3 times, most recently from ea31711 to 50cf10d Compare March 5, 2021 02:17
Signed-off-by: Alex Collins <alex_collins@intuit.com>
alexec added 8 commits March 7, 2021 08:09
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec changed the title ci: Go faster please ci: Github actions refactor Mar 8, 2021
alexec added 6 commits March 8, 2021 09:56
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec marked this pull request as ready for review March 8, 2021 19:07

gen "Test Docker Executor" test-executor docker
gen "Test Emissary Executor" test-executor emissary
gen "Test K8SAPI Executor" test-executor k8sapi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: K8SAPI -> K8sapi to be consistent with others (not all capitalized)

@@ -0,0 +1,76 @@
# This is an auto-generated file. DO NOT EDIT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the source of these generated files?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gen-ci.sh

Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
Copy link
Contributor Author

alexec commented Mar 8, 2021

Thank you Derek.

@alexec alexec merged commit 814944c into argoproj:master Mar 8, 2021
@alexec alexec deleted the fast branch March 8, 2021 22:57
@@ -39,3 +39,4 @@ git-ask-pass.sh
pprof
pkg/apiclient/sensor/sensor.swagger.json
pkg/apiclient/eventsource/eventsource.swagger.json
/argoexec-linux-amd64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexec Was this committed in error? If so, can I remove?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've a follow-up PR to fix this: #5335 - you could approve that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@simster7 simster7 mentioned this pull request Mar 15, 2021
27 tasks
@simster7 simster7 mentioned this pull request Mar 29, 2021
77 tasks
@agilgur5 agilgur5 added the area/build Build or GithubAction/CI issues label Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Build or GithubAction/CI issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants