Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controller): Workflow-level retryStrategy/resubmit pending pods by default. Closes #3918 #3965

Merged
merged 17 commits into from
Sep 21, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Sep 8, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Closes #3918
Related to ##2385

Changes

  • Support retryStrategy at workflow level.
  • Completely remove resubmitPendingPods and always resubmit them.

@alexec alexec added the type/feature Feature request label Sep 8, 2020
@alexec alexec changed the title feat(controller): Workflow-level resubmitPendingPods. Closes #3918 feat(controller): Workflow-level retryStrategy. Closes #3918 Sep 11, 2020
@alexec alexec changed the title feat(controller): Workflow-level retryStrategy. Closes #3918 feat(controller): Workflow-level retryStrategy + always resubmit pending pods. Closes #3918 Sep 12, 2020
@alexec alexec changed the title feat(controller): Workflow-level retryStrategy + always resubmit pending pods. Closes #3918 feat(controller): Workflow-level retryStrategy/resubmit pending pods by default. Closes #3918 Sep 12, 2020
@alexec
Copy link
Contributor Author

alexec commented Sep 13, 2020

FAIL: TestFunctionalSuite/TestRetryStrategy 

@alexec
Copy link
Contributor Author

alexec commented Sep 13, 2020

FAIL: TestArgoServerSuite/TestWorkflowService/Terminate
FAIL: TestArgoServerSuite/TestWorkflowService/Resubmit
FAIL: TestCLIWithServerSuite/TestNodeSuspendResume

@alexec alexec marked this pull request as ready for review September 14, 2020 16:09
@alexec alexec requested a review from jessesuen as a code owner September 14, 2020 16:09
@alexec alexec added this to the v2.12 milestone Sep 14, 2020
@alexec alexec marked this pull request as draft September 14, 2020 16:09
@alexec alexec marked this pull request as ready for review September 16, 2020 19:46
@alexec
Copy link
Contributor Author

alexec commented Sep 16, 2020

FAIL: TestFunctionalSuite/TestDeletingRunningPodWithOrErrorRetryPolicy (39.99s)

@alexec alexec requested a review from sarabala1979 September 18, 2020 17:22
@alexec alexec requested a review from simster7 September 18, 2020 17:22
@alexec alexec merged commit fdf0b05 into argoproj:master Sep 21, 2020
@alexec alexec deleted the resubmit branch September 21, 2020 22:37
@jamesgunnfiveai
Copy link

Hi folks - we've just bumped into a problem where some users with clients on 2.12.x can't parse our workflows that contain resubmitPendingPods: true whereas 2.11.x clients can. I believe this is a result of this MR removing the field in versions >=2.12 (this is solved by just having them downgrade to 2.11.x for now). Just curious whether it was intentional that this landed in a minor version bump as I would have thought it should be major according to semver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature Feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tolerate deleted resources
3 participants