test(controller): Add memoization tests. See #3214 #3455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexec
commented
Jul 11, 2020
| @@ -592,6 +592,16 @@ func (s *ArgoServerSuite) TestWorkflowService() { | |||
| Equal("Stopped with strategy 'Terminate'") | |||
| }) | |||
|
|
|||
| s.Run("Resubmit", func() { | |||
There was a problem hiding this comment.
this is just a smoke test - was missing
alexec
commented
Jul 12, 2020
| my-wf-lzarl: | ||
| phase: Failed | ||
| `) | ||
| wf, err := util.FormulateResubmitWorkflow(wf, true) |
There was a problem hiding this comment.
really tough to test, the memozied workflow produced is al
alexec
commented
Jul 13, 2020
workflow/controller/operator.go
Outdated
| @@ -1872,7 +1872,7 @@ func (woc *wfOperationCtx) executeContainer(nodeName string, templateScope strin | |||
| node := woc.wf.GetNodeByName(nodeName) | |||
| if node == nil { | |||
| node = woc.initializeExecutableNode(nodeName, wfv1.NodeTypePod, templateScope, tmpl, orgTmpl, opts.boundaryID, wfv1.NodePending) | |||
| } else if !isResubmitAllowed(tmpl) && !node.Pending() { | |||
| } else if !node.StartedAt.IsZero() && (!isResubmitAllowed(tmpl) && !node.Pending()) { | |||
There was a problem hiding this comment.
fixed by @sarabala1979 in #3141
There was a problem hiding this comment.
@sarabala1979 you changed this condition from:
!isResubmitAllowed(tmpl) || !node.Pending()
to
!isResubmitAllowed(tmpl) && !node.Pending()
and this has fixed the same memoization bug I was trying to fix - was that your intention?
simster7
approved these changes
Jul 13, 2020
alexec
added a commit
that referenced
this pull request
Jul 13, 2020
alexec
added a commit
to alexec/argo-workflows
that referenced
this pull request
Jul 13, 2020
6 tasks
alexec
added a commit
that referenced
this pull request
Jul 13, 2020
alexec
added a commit
that referenced
this pull request
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".See #3214