Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: fix(controller): detect when pending pod was deleted. Fixes #2711 #2712

Closed
wants to merge 1 commit into from
Closed

WIP: fix(controller): detect when pending pod was deleted. Fixes #2711 #2712

wants to merge 1 commit into from

Conversation

vmanucharyan
Copy link
Contributor

@vmanucharyan vmanucharyan commented Apr 16, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Fixes #2711

@vmanucharyan vmanucharyan changed the title fix(controller): detect when pending pod was deleted. Fixes #2711 WIP: fix(controller): detect when pending pod was deleted. Fixes #2711 Apr 16, 2020
@vmanucharyan
Copy link
Contributor Author

looks like i broke resubmitPendingPods functionality and it actually resolves my original issue 😁sorry if I wasted your time, closing this

@simster7 simster7 reopened this Apr 16, 2020
@simster7
Copy link
Member

Sorry, reopened by mistake. Line 800 is indeed the problematic line, so you were on the right track! The solution is a bit more involved than this, though. I'll get a fix out by the next release.

Thanks for trying to fix this yourself!

@simster7 simster7 closed this Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pod gets stuck forever in pending state if it was deleted before initialisation
2 participants