Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Skip flakey tests in operator_template_scope_test.go. See #2432 #2433

Merged
merged 2 commits into from
Mar 13, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Mar 13, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the USERS.md.
  • I've signed the CLA and required builds are green.

See #2432

Copy link
Member

@simster7 simster7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we at least add a // TODO: Fix this test?

@alexec
Copy link
Contributor Author

alexec commented Mar 13, 2020

Can we at least add a // TODO: Fix this test?

I've created a Github issue to fix the test.

@codecov
Copy link

codecov bot commented Mar 13, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@3f8be0c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2433   +/-   ##
=========================================
  Coverage          ?   13.02%           
=========================================
  Files             ?       71           
  Lines             ?    25122           
  Branches          ?        0           
=========================================
  Hits              ?     3273           
  Misses            ?    21428           
  Partials          ?      421

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f8be0c...12c9a64. Read the comment docs.

@alexec alexec merged commit 7094433 into argoproj:master Mar 13, 2020
@alexec alexec deleted the skip-tests branch March 13, 2020 17:20
@dtaniwaki dtaniwaki mentioned this pull request Mar 23, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants