Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove leftover code #14109

Merged
merged 1 commit into from
Jan 22, 2025
Merged

chore: remove leftover code #14109

merged 1 commit into from
Jan 22, 2025

Conversation

jswxstw
Copy link
Member

@jswxstw jswxstw commented Jan 21, 2025

remove leftover code in #5232

@jswxstw
chore: remove leftover code
f091d22 
Signed-off-by: oninowang <oninowang@tencent.com>
@jswxstw jswxstw requested a review from alexec January 21, 2025 12:59
@jswxstw
Copy link
Member Author

jswxstw commented Jan 22, 2025

/retest

tczhao
tczhao approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@tczhao tczhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix
looks like everywhere else uses http.RoundTripper instead of WebsocketRoundTripper

@tczhao tczhao merged commit 514ea37 into argoproj:main Jan 22, 2025
31 checks passed
@jswxstw jswxstw deleted the chore-rm-code branch January 22, 2025 03:10
alexec pushed a commit that referenced this pull request Jan 27, 2025
@jswxstw @alexec
chore: remove leftover code (#14109)
3077c06 
Signed-off-by: oninowang <oninowang@tencent.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tczhao tczhao tczhao approved these changes

@alexec alexec Awaiting requested review from alexec

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jswxstw @tczhao