Fixed: failed to save outputs: verify serviceaccount default:default has necessary privileges

cmd/argoexec/commands/root.go

@@ -2,6 +2,7 @@ package commands
 
 import (
 	"encoding/json"
+	"github.com/argoproj/argo/errors"
 	"os"
 
 	"github.com/argoproj/pkg/cli"
@@ -66,7 +67,7 @@ func NewRootCommand() *cobra.Command {
 
 func initExecutor() *executor.WorkflowExecutor {
 	config, err := clientConfig.ClientConfig()
-	checkErr(err)
+	checkErr(errors.Wrap(err, errors.CodeInternal, "Failed to initialize client config in Sidecar"))
 
 	namespace, _, err := clientConfig.Namespace()
 	checkErr(err)
@@ -80,7 +81,7 @@ func initExecutor() *executor.WorkflowExecutor {
 	}
 
 	tmpl, err := executor.LoadTemplate(podAnnotationsPath)
-	checkErr(err)
+	checkErr(errors.Wrap(err, errors.CodeInternal, "Failed to load the template"))
 
 	var cre executor.ContainerRuntimeExecutor
 	switch os.Getenv(common.EnvVarContainerRuntimeExecutor) {
@@ -93,7 +94,7 @@ func initExecutor() *executor.WorkflowExecutor {
 	default:
 		cre, err = docker.NewDockerExecutor()
 	}
-	checkErr(err)
+	checkErr(errors.Wrap(err, errors.CodeInternal, "Failed to initialize Executor"))
 
 	wfExecutor := executor.NewExecutor(clientset, podName, namespace, podAnnotationsPath, cre, *tmpl)
 	yamlBytes, _ := json.Marshal(&wfExecutor.Template)

cmd/argoexec/commands/wait.go

@@ -1,6 +1,7 @@
 package commands
 
 import (
+	"github.com/argoproj/argo/errors"
 	"time"
 
 	"github.com/argoproj/pkg/stats"
@@ -31,40 +32,41 @@ func waitContainer() error {
 	// Wait for main container to complete
 	err := wfExecutor.Wait()
 	if err != nil {
-		wfExecutor.AddError(err)
+
+		wfExecutor.AddError(errors.Wrap(err, errors.CodeInternal, " Wait container failed to wait for main container to complete "))
 		// do not return here so we can still try to kill sidecars & save outputs
 	}
 	err = wfExecutor.KillSidecars()
 	if err != nil {
-		wfExecutor.AddError(err)
+		wfExecutor.AddError(errors.Wrap(err, errors.CodeInternal, " Wait container kill failed"))
 		// do not return here so we can still try save outputs
 	}
 	logArt, err := wfExecutor.SaveLogs()
 	if err != nil {
-		wfExecutor.AddError(err)
+		wfExecutor.AddError(errors.Wrap(err, errors.CodeInternal, " Wait container failed to save the logs"))
 		return err
 	}
 	// Saving output parameters
 	err = wfExecutor.SaveParameters()
 	if err != nil {
-		wfExecutor.AddError(err)
+		wfExecutor.AddError(errors.Wrap(err, errors.CodeInternal, " Wait container failed to save the parameters"))
 		return err
 	}
 	// Saving output artifacts
 	err = wfExecutor.SaveArtifacts()
 	if err != nil {
-		wfExecutor.AddError(err)
+		wfExecutor.AddError(errors.Wrap(err, errors.CodeInternal, " Wait container failed to save the artifacts"))
 		return err
 	}
 	// Capture output script result
 	err = wfExecutor.CaptureScriptResult()
 	if err != nil {
-		wfExecutor.AddError(err)
+		wfExecutor.AddError(errors.Wrap(err, errors.CodeInternal, " Wait container failed to capture the script results"))
 		return err
 	}
 	err = wfExecutor.AnnotateOutputs(logArt)
 	if err != nil {
-		wfExecutor.AddError(err)
+		wfExecutor.AddError(errors.Wrap(err, errors.CodeInternal, " Wait container failed to annotate the outputs"))
 		return err
 	}
 	return nil

workflow/executor/executor.go

@@ -180,7 +180,7 @@ func (we *WorkflowExecutor) LoadArtifacts() error {
 		if art.Mode != nil {
 			err = os.Chmod(artPath, os.FileMode(*art.Mode))
 			if err != nil {
-				return errors.InternalWrapError(err)
+				return errors.InternalWrapError(err, "Container failed to load the artifacts")
 			}
 		}
 	}
@@ -205,7 +205,7 @@ func (we *WorkflowExecutor) StageFiles() error {
 	}
 	err := ioutil.WriteFile(filePath, body, 0644)
 	if err != nil {
-		return errors.InternalWrapError(err)
+		return errors.InternalWrapError(err, "Container failed to load the stage files")
 	}
 	return nil
 }