-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the arguments being passed to kubectl patch
#1266
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@sarabala1979 can you check?
@ian-howell - @sarabala1979 explained that this is the intended behavior which I agree with. We want the default behavior to use strategic merge patching (which is the kubectl default). If we need other merge types, we can supply it as a different field.
This should be working for strategic merge patching. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intention is for patch to use strategic merge patching. If we need to support other styles patching, we should provide it as an option
@jessesuen I understand. I'll take a second look at this tomorrow to suss out why patches are failing in my workflows |
I'm not sure I understand. Without the
@jessesuen @sarabala1979 Could one of you provide an example patch to be used with this feature? EDIT: On further inspection, I've found that patching doesn't work for me because I am using Custom Resources. I'll go ahead and work on getting other patch strategies as an option, as per @jessesuen's suggestion |
* The `kubectl patch` will fail if the `--type merge` argument is not passed. It also requires for the patch manifest to be enclosed in single quotes. * This also updates the k8s resource example
9702c44
to
4c1d7cd
Compare
Closing in favor of #1269 |
yes, correct. strategic-merge-patch is supported only standard resources |
The
kubectl patch
will fail if the--type merge
argument is notpassed. It also requires for the patch manifest to be enclosed in single
quotes.
This also updates the k8s resource example
Resolves #1223