-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Flakey test about lifecycle hooks #11534
fix: Flakey test about lifecycle hooks #11534
Conversation
90d5cbd
to
4076420
Compare
Docs are failing by 500 error in Node server, so I will retry later. |
0a989c2
to
284bffb
Compare
Signed-off-by: toyamagu-2021 <toyamagu2021@gmail.com>
Signed-off-by: toyamagu-2021 <toyamagu2021@gmail.com>
Signed-off-by: toyamagu-2021 <toyamagu2021@gmail.com>
Signed-off-by: toyamagu-2021 <toyamagu2021@gmail.com>
Signed-off-by: toyamagu-2021 <toyamagu2021@gmail.com>
Signed-off-by: toyamagu-2021 <toyamagu2021@gmail.com>
Signed-off-by: toyamagu-2021 <toyamagu2021@gmail.com>
Signed-off-by: toyamagu-2021 <toyamagu2021@gmail.com>
Signed-off-by: toyamagu-2021 <toyamagu2021@gmail.com>
Signed-off-by: toyamagu-2021 <toyamagu2021@gmail.com>
Signed-off-by: toyamagu-2021 <toyamagu2021@gmail.com>
284bffb
to
1ec76f7
Compare
Signed-off-by: toyamagu-2021 <toyamagu2021@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question, otherwise LGTM. Thanks for fixing some of the flaky tests, that's very helpful!!!
container: | ||
image: alpine:latest | ||
image: argoproj/argosay:v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what was the purpose of changing some of these from Alpine to argosay
? didn't see a mention of that in the PR description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Not essential, just the same as the others.
https://github.com/argoproj/argo-workflows/blob/20d0923611f1df6b7147c3547aeeff6b6bfecf18/test/e2e/hooks_test.go#L89C1-L99
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah consistency with this rest of this file, gotcha.
I searched the rest of the codebase and found that alpine:latest
is used with some frequency.
So didn't think that this one particularly stood out, but in the context of the file, it appears to have been inconsistent. Thanks for the clarification!
Signed-off-by: toyamagu-2021 <toyamagu2021@gmail.com>
Signed-off-by: toyamagu-2021 <toyamagu2021@gmail.com> Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Signed-off-by: toyamagu-2021 toyamagu2021@gmail.com
Relates #10807
Motivation
Modifications
Running
lifecycle hookTestTemplateLevelHooksWaitForTriggeredHookAndRespectSynchronization
Verification
Succeed 100% in 4x2+1=9 times