Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Switch to use kong/httpbin to support arm64. Fixes #10427 #11533

Merged
merged 3 commits into from
Aug 8, 2023

Conversation

sonbui00
Copy link
Member

@sonbui00 sonbui00 commented Aug 6, 2023

Fixes #10427

Motivation

Run local development with httpbin on Mac M1 (ard64)

Modifications

Replace out date image httpbin with mccutchen/go-httpbin kong/httpbin

Verification

Tested locally/manually + Run make test

Signed-off-by: Son Bui <sonbv00@gmail.com>
@terrytangyuan terrytangyuan changed the title fix: httpbin image outdate - can not run on arm64 - #10427 fix: httpbin image outdate - can not run on arm64. Fixes #10427 Aug 8, 2023
@terrytangyuan terrytangyuan changed the title fix: httpbin image outdate - can not run on arm64. Fixes #10427 fix: Switch to use kong/httpbin to support arm64. Fixes #10427 Aug 8, 2023
@terrytangyuan terrytangyuan enabled auto-merge (squash) August 8, 2023 00:46
@terrytangyuan terrytangyuan merged commit 6e50cb0 into argoproj:master Aug 8, 2023
terrytangyuan added a commit that referenced this pull request Aug 11, 2023
Signed-off-by: Son Bui <sonbv00@gmail.com>
Co-authored-by: Yuan (Terry) Tang <terrytangyuan@gmail.com>
dpadhiar pushed a commit to dpadhiar/argo-workflows that referenced this pull request May 9, 2024
argoproj#11533)

Signed-off-by: Son Bui <sonbv00@gmail.com>
Co-authored-by: Yuan (Terry) Tang <terrytangyuan@gmail.com>
Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace httpbin with something up to date
2 participants