fix: Devcontainer resets /etc/hosts (#11439) #11440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
196d864 to
eb618f7
Compare
agilgur5
reviewed
Jul 25, 2023
Signed-off-by: Byeonggon Lee <binkoni@gonnux.com>
eb618f7 to
85f10ab
Compare
agilgur5
approved these changes
Jul 26, 2023
terrytangyuan
approved these changes
Jul 27, 2023
45 tasks
5 tasks
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Mar 12, 2024
Signed-off-by: Byeonggon Lee <binkoni@gonnux.com>
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
May 6, 2024
Signed-off-by: Byeonggon Lee <binkoni@gonnux.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11439
Motivation
A container created by Devcontainer keeps resetting /etc/hosts whenever I reboot or restart the container.
Modifications
.devcontainer/devcontainer.json
.devcontainer/pre-build.sh
.devcontainer/post-start.shVerification
To ensure this issue is fixed, I manually tested by running devcontainer commands that after I made this change.
I also tested with VsCode devcontainer extension.