fix(server): don't grab SAs if SSO RBAC is not enabled #11426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the `ResourceCache` creates a `ServiceAccountLister` `informer`, but this is only used when RBAC is enabled
- if RBAC is not enabled, it is not used, and so does not need to be created
- also, if RBAC is not enabled, the Server's `ClusterRole` should not require `serviceaccount` permissions
- without this change, whenever SSO is enabled, the `ClusterRole` will require `serviceaccount` permissions, despite not actually needing it (i.e. not "least privilege")
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
|
I don't think the CI errors here are related as I didn't change the actual manifests and none of the failures are API failures. I assume flaky tests? |
terrytangyuan
approved these changes
Jul 28, 2023
terrytangyuan
pushed a commit
that referenced
this pull request
Aug 13, 2023
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
dpadhiar
pushed a commit
to dpadhiar/argo-workflows
that referenced
this pull request
May 9, 2024
Signed-off-by: Anton Gilgur <agilgur5@gmail.com> Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes argoproj/argo-helm#2159, Fixes argoproj/argo-helm#1624
Motivation
ResourceCachecreates aServiceAccountListerinformer, but this is only used when RBAC is enabledClusterRoleshould not requireserviceaccountpermissionsClusterRolewill requireserviceaccountpermissions, despite not actually needing it (i.e. not "least privilege")Modifications
ResourceCachewhen SSO RBAC is enabledVerification
There's no unit tests for this specific file / for the
NewArgoServerfunction. I might be able to write an E2E test for this, but am still learning that part of the codebase.rbac.enabled: true. Then running a subset of the Server E2E tests. Non-trivial change as far as I can tell so far, and may require a decent bit of modifications to theMakefileetc to run a new test + install a new manifest as well 😅Future Work
I feel like it might make sense to rename / move
resource_cache.go? It is only used by SSO RBAC and nothing else right now, as far as I can tell. The name feels misleading as a result as it seems more generic.