Skip to content

Commit

Permalink
fix: Skip TestExitHookWithExpression() completely (#8761)
Browse files Browse the repository at this point in the history
* fix: Skip TestExitHookWithExpression() completely

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* fix: skip

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
  • Loading branch information
terrytangyuan authored and sarabala1979 committed Jun 20, 2022
1 parent a1ba421 commit 479763c
Showing 1 changed file with 0 additions and 33 deletions.
33 changes: 0 additions & 33 deletions test/e2e/hooks_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -91,39 +91,6 @@ spec:
})
}

func (s *HooksSuite) TestExitHookWithExpression() {
s.Given().
Workflow(`apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
generateName: lifecycle-hook-exit-hook-
spec:
entrypoint: main
templates:
- name: main
steps:
- - name: step-1
hooks:
exit:
expression: steps["step-1"].status == "Running"
template: http
template: http
- name: http
http:
url: "http://httpstat.us"
`).When().
SubmitWorkflow().
WaitForWorkflow(fixtures.ToBeSucceeded).
Then().
ExpectWorkflow(func(t *testing.T, metadata *v1.ObjectMeta, status *v1alpha1.WorkflowStatus) {
assert.Equal(t, v1alpha1.WorkflowRunning, status.Phase)
}).ExpectWorkflowNode(func(status v1alpha1.NodeStatus) bool {
return strings.Contains(status.Name, "hook")
}, func(t *testing.T, status *v1alpha1.NodeStatus, pod *apiv1.Pod) {
assert.Equal(t, v1alpha1.NodeSucceeded, status.Phase)
})
}

func TestHooksSuite(t *testing.T) {
suite.Run(t, new(HooksSuite))
}

0 comments on commit 479763c

Please sign in to comment.