Fixed : Validate the secret credentials name and key (#1358)

* CheckandEstimate implementation * fixed variable rename * fixed gofmt * fixed feedbacks * Fixed Issue1355 * fixed style * Delete e2e_temp.tmp
argoproj · May 7, 2019 · 24680b7 · 24680b7
1 parent f641d84
commit 24680b7
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/workflow/controller/workflowpod.go b/workflow/controller/workflowpod.go
@@ -946,7 +946,7 @@ func createSecretVolume(volMap map[string]apiv1.Volume, art wfv1.Artifact, keyMa
 }
 
 func createSecretVal(volMap map[string]apiv1.Volume, secret *apiv1.SecretKeySelector, keyMap map[string]bool) {
-	if secret == nil {
+	if secret == nil || secret.Name == "" || secret.Key == "" {
 		return
 	}
 	if vol, ok := volMap[secret.Name]; ok {