Fixed: Support hostAliases in WorkflowSpec #1265 (#1365)

* Fixed : Support hostAliases in WorkflowSpec #1265

api/openapi-spec/swagger.json

@@ -825,6 +825,13 @@
           "description": "DAG template subtype which runs a DAG",
           "$ref": "#/definitions/io.argoproj.workflow.v1alpha1.DAGTemplate"
         },
+        "hostAliases": {
+          "description": "HostAliases is an optional list of hosts and IPs that will be injected into the pod spec",
+          "type": "array",
+          "items": {
+            "$ref": "#/definitions/io.k8s.api.core.v1.HostAlias"
+          }
+        },
         "initContainers": {
           "description": "InitContainers is a list of containers which run before the main container.",
           "type": "array",
@@ -1153,6 +1160,13 @@
           "description": "Entrypoint is a template reference to the starting point of the workflow",
           "type": "string"
         },
+        "hostAliases": {
+          "description": "HostAliases is an optional list of hosts and IPs that will be injected into the pod spec",
+          "type": "array",
+          "items": {
+            "$ref": "#/definitions/io.k8s.api.core.v1.HostAlias"
+          }
+        },
         "hostNetwork": {
           "description": "Host networking requested for this workflow pod. Default to false.",
           "type": "boolean"

pkg/apis/workflow/v1alpha1/types.go

@@ -164,6 +164,9 @@ type WorkflowSpec struct {
 
 	// Priority to apply to workflow pods.
 	PodPriority *int32 `json:"podPriority,omitempty"`
+
+	// HostAliases is an optional list of hosts and IPs that will be injected into the pod spec
+	HostAliases []apiv1.HostAlias `json:"hostAliases,omitempty"`
 }
 
 // Template is a reusable and composable unit of execution in a workflow
@@ -252,6 +255,9 @@ type Template struct {
 
 	// Priority to apply to workflow pods.
 	Priority *int32 `json:"priority,omitempty"`
+
+	// HostAliases is an optional list of hosts and IPs that will be injected into the pod spec
+	HostAliases []apiv1.HostAlias `json:"hostAliases,omitempty"`
 }
 
 // Inputs are the mechanism for passing parameters, artifacts, volumes from one template to another

test/e2e/functional/template_level_host_aliases.yaml

@@ -0,0 +1,17 @@
+apiVersion: argoproj.io/v1alpha1
+kind: Workflow
+metadata:
+  generateName: template-level-host-aliases-
+spec:
+  entrypoint: nslookup
+
+  templates:
+  - name: nslookup
+    hostAliases:
+      - ip: "127.0.0.1"
+        hostnames:
+          - "argo.io"
+    container:
+      image: alpine:latest
+      command: [sh, -c]
+      args: [" nslookup argo.io"]

test/e2e/functional/workflow_level_host_aliases.yaml

@@ -0,0 +1,16 @@
+apiVersion: argoproj.io/v1alpha1
+kind: Workflow
+metadata:
+  generateName: workflow_level_host_aliases-
+spec:
+  entrypoint: nslookup
+  hostAliases:
+    - ip: "127.0.0.1"
+      hostnames:
+        - "argo.io"
+  templates:
+  - name: nslookup
+    container:
+      image: alpine:latest
+      command: [sh, -c]
+      args: ["nslookup argo.io"]

test/e2e/functional/workflow_teemplate_level_host_aliases.yaml

@@ -0,0 +1,21 @@
+apiVersion: argoproj.io/v1alpha1
+kind: Workflow
+metadata:
+  generateName: workflow-template-level-host-aliases-
+spec:
+  entrypoint: nslookup
+  hostAliases:
+    - ip: "127.0.0.1"
+      hostnames:
+        - "argo.io"
+
+  templates:
+  - name: nslookup
+    hostAliases:
+      - ip: "124.0.0.1"
+        hostnames:
+          - "argo1.io"
+    container:
+      image: alpine:latest
+      command: [sh, -c]
+      args: ["nslookup argo.io argo1.io "]

workflow/controller/workflowpod.go

@@ -488,6 +488,11 @@ func addSchedulingConstraints(pod *apiv1.Pod, wfSpec *wfv1.WorkflowSpec, tmpl *w
 	} else if wfSpec.SchedulerName != "" {
 		pod.Spec.SchedulerName = wfSpec.SchedulerName
 	}
+
+	// set hostaliases
+	pod.Spec.HostAliases = append(pod.Spec.HostAliases, wfSpec.HostAliases...)
+	pod.Spec.HostAliases = append(pod.Spec.HostAliases, tmpl.HostAliases...)
+
 }
 
 // addVolumeReferences adds any volumeMounts that a container/sidecar is referencing, to the pod.spec.volumes

workflow/controller/workflowpod_test.go

@@ -612,3 +612,33 @@ func TestTemplateLocalVolumes(t *testing.T) {
 		assert.Contains(t, pod.Spec.Volumes, v)
 	}
 }
+
+// TestWFLevelHostAliases verifies the ability to carry forward workflow level HostAliases to Podspec
+func TestWFLevelHostAliases(t *testing.T) {
+	woc := newWoc()
+	woc.wf.Spec.HostAliases = []apiv1.HostAlias{
+		{IP: "127.0.0.1"},
+		{IP: "127.0.0.1"},
+	}
+	woc.executeContainer(woc.wf.Spec.Entrypoint, &woc.wf.Spec.Templates[0], "")
+	podName := getPodName(woc.wf)
+	pod, err := woc.controller.kubeclientset.CoreV1().Pods("").Get(podName, metav1.GetOptions{})
+	assert.Nil(t, err)
+	assert.NotNil(t, pod.Spec.HostAliases)
+
+}
+
+// TestTmplLevelHostAliases verifies the ability to carry forward template level HostAliases to Podspec
+func TestTmplLevelHostAliases(t *testing.T) {
+	woc := newWoc()
+	woc.wf.Spec.Templates[0].HostAliases = []apiv1.HostAlias{
+		{IP: "127.0.0.1"},
+		{IP: "127.0.0.1"},
+	}
+	woc.executeContainer(woc.wf.Spec.Entrypoint, &woc.wf.Spec.Templates[0], "")
+	podName := getPodName(woc.wf)
+	pod, err := woc.controller.kubeclientset.CoreV1().Pods("").Get(podName, metav1.GetOptions{})
+	assert.Nil(t, err)
+	assert.NotNil(t, pod.Spec.HostAliases)
+
+}