Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix markdown rendering #4109

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

gonmmarques
Copy link
Contributor

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Currently in https://argoproj.github.io/argo-rollouts/analysis/datadog/ the following would occur
image

this PR addresses it by fixing the rendering of the YAML.

Signed-off-by: Gonçalo Montalvão Marques <9379664+gonmmarques@users.noreply.github.com>
Copy link

sonarqubecloud bot commented Feb 5, 2025

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Published E2E Test Results

  4 files    4 suites   3h 9m 14s ⏱️
113 tests 104 ✅  7 💤 2 ❌
456 runs  424 ✅ 28 💤 4 ❌

For more details on these failures, see this check.

Results for commit 3791362.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Published Unit Test Results

2 294 tests   2 294 ✅  2m 59s ⏱️
  128 suites      0 💤
    1 files        0 ❌

Results for commit 3791362.

@zachaller zachaller merged commit 6761843 into argoproj:master Feb 5, 2025
22 checks passed
@gonmmarques gonmmarques deleted the patch-1 branch February 6, 2025 11:44
meeech pushed a commit to CircleCI-Public/argo-rollouts that referenced this pull request Feb 10, 2025
Signed-off-by: Gonçalo Montalvão Marques <9379664+gonmmarques@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants