fix: loop when paused and completed

argoproj · Feb 15, 2025 · b21eecf · b21eecf
1 parent 76b3898
commit b21eecf
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/rollout/sync.go b/rollout/sync.go
@@ -492,8 +492,9 @@ func (c *rolloutContext) checkPausedConditions() error {
 
 	var updatedConditions []*v1alpha1.RolloutCondition
 
-	if (isPaused != progCondPaused) && !abortCondExists {
+	if (isPaused != progCondPaused) && !abortCondExists && c.rollout.Status.StableRS != c.rollout.Status.CurrentPodHash {
 		if isPaused {
+			// TODO: pause
 			updatedConditions = append(updatedConditions, conditions.NewRolloutCondition(v1alpha1.RolloutProgressing, corev1.ConditionUnknown, conditions.RolloutPausedReason, conditions.RolloutPausedMessage))
 		} else {
 			updatedConditions = append(updatedConditions, conditions.NewRolloutCondition(v1alpha1.RolloutProgressing, corev1.ConditionUnknown, conditions.RolloutResumedReason, conditions.RolloutResumedMessage))
@@ -633,6 +634,7 @@ func (c *rolloutContext) calculateRolloutConditions(newStatus v1alpha1.RolloutSt
 				rsName = c.newRS.Name
 			}
 			msg := fmt.Sprintf(conditions.ReplicaSetCompletedMessage, rsName)
+			// TODO: pause
 			progressingCondition := conditions.NewRolloutCondition(v1alpha1.RolloutProgressing, corev1.ConditionTrue, conditions.NewRSAvailableReason, msg)
 			conditions.SetRolloutCondition(&newStatus, *progressingCondition)
 		case conditions.RolloutProgressing(c.rollout, &newStatus) || becameUnhealthy: