Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(argo-cd): Add missing permission for Dynamic Cluster Distribution #2754

Merged
merged 1 commit into from
Jun 9, 2024

Conversation

yu-croco
Copy link
Collaborator

@yu-croco yu-croco commented Jun 9, 2024

Resolves #2743

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

resources:
- configmaps
resourceNames:
- argocd-app-controller-shard-cm
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝
Ref: https://argo-cd.readthedocs.io/en/stable/operator-manual/dynamic-cluster-distribution/#working-of-dynamic-distribution

The Application Controller will create a new ConfigMap named argocd-app-controller-shard-cm to store the Controller <-> Shard mapping. The mapping would look like below for each shard:

@yu-croco yu-croco marked this pull request as ready for review June 9, 2024 01:21
@tico24 tico24 merged commit 377332f into argoproj:main Jun 9, 2024
12 checks passed
@yu-croco yu-croco deleted the fix-dynamic-cluster-distribution branch June 14, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application Controller lacks sufficient permissions for dynamicClusterDistribution in namespaced installations
3 participants