Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(argo-workflows): Moving CRDs to the Templates folder #1435

Conversation

christophercutajar
Copy link

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

This PR is related to #1430. This PR includes:

  • Moving CRDs to the templates folder
  • Adding crds variable in the `values.yaml

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

Changes are automatically published when merged to main. They are not published on branches.

@christophercutajar christophercutajar changed the title Moving CRDs to the Templates folder bug(Moving CRDs to the Templates folder) Aug 31, 2022
@christophercutajar christophercutajar changed the title bug(Moving CRDs to the Templates folder) fix(Moving CRDs to the Templates folder) Aug 31, 2022
Signed-off-by: christophercutajar <60098546+christophercutajar@users.noreply.github.com>
@christophercutajar christophercutajar force-pushed the christophercutajar/issue_1430 branch from c584392 to 6374757 Compare August 31, 2022 15:45
@christophercutajar christophercutajar changed the title fix(Moving CRDs to the Templates folder) fix(argo-workflows): Moving CRDs to the Templates folder Aug 31, 2022
@yu-croco
Copy link
Collaborator

yu-croco commented Sep 1, 2022

I think this PR has breaking change for existing users, so we need to describe how to adopt existing CRDs, like #1342 . 👀

argo-workflows does not have upgrade guid for now, like https://github.com/argoproj/argo-helm/tree/main/charts/argo-cd#upgrading , so I think we need to add this section on argo-workflow's README as well.

WDYT @stefansedich @paguos @vladlosev @yann-soubeyrand @jmeridth ? 🙋

Copy link
Member

@jmeridth jmeridth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like the conversation in #1430 to continue before we merge this.

@jmeridth
Copy link
Member

This was completed with #1472

@jmeridth jmeridth closed this Oct 24, 2022
@christophercutajar christophercutajar deleted the christophercutajar/issue_1430 branch October 24, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants