Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support podman and older version of docker #8870

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

zachaller
Copy link
Contributor

Podman and older versions of docker do not support multiple args
on a single line. It was recently added to docker in this commit
moby/buildkit#1692 and podman still dose not have support
for it.

Signed-off-by: zachaller zachaller@hotmail.com

Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@crenshaw-dev
Copy link
Member

It's been 3 hours, looks like the build is stuck. @alexmt or @jannfis can you restart the checks?

Podman and older versions of docker do not support multiple args
on a single line. It was recently added to docker in this commit
moby/buildkit#1692 and podman still dose not have support
for it.

Signed-off-by: zachaller <zachaller@hotmail.com>
@crenshaw-dev crenshaw-dev merged commit a10b28e into argoproj:master Mar 23, 2022
@zachaller zachaller deleted the podman-args branch March 24, 2022 14:04
wojtekidd pushed a commit to wojtekidd/argo-cd that referenced this pull request Apr 25, 2022
Podman and older versions of docker do not support multiple args
on a single line. It was recently added to docker in this commit
moby/buildkit#1692 and podman still dose not have support
for it.

Signed-off-by: zachaller <zachaller@hotmail.com>
Signed-off-by: wojtekidd <wojtek.cichon@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants