Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade kustomize to v3.8.2 version #4429

Closed
wants to merge 1 commit into from

Conversation

tooooots
Copy link

Bump Kustomize version from v3.8.1 to v3.8.2. This version includes a fix for:

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I've signed the CLA and my build is green (troubleshooting builds).

Kustomize 3.8.2 has a fix for:

- Avoiding Prefix Transformer for Namespace resource
kubernetes-sigs/kustomize#2742
@CLAassistant
Copy link

CLAassistant commented Sep 25, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

Merging #4429 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4429   +/-   ##
=======================================
  Coverage   41.18%   41.18%           
=======================================
  Files         122      122           
  Lines       16584    16584           
=======================================
  Hits         6830     6830           
  Misses       8772     8772           
  Partials      982      982           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4347a3c...8ba6694. Read the comment docs.

@jannfis
Copy link
Member

jannfis commented Sep 28, 2020

Hm, it seems that this patch version change in Kustomize has changed a little more in its behaviour. Can you please check why e2e tests are failing?

@jessesuen
Copy link
Member

jessesuen commented Oct 8, 2020

Looks like a potential breakage with upstream kustomize. This is not safe to merge. Maybe try with 3.8.5?

@tooooots tooooots closed this Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants