fix: argocd notification controller app client permission issue (cherry-pick #16057)

[gcp-cherry-pick-bot]

Cherry-picked fix: argocd notification controller app cluster permission issue (#16057)

• if applicationNamespaces is not provided as input parameter, then use namespaced appClient

Signed-off-by: May Zhang may_zhang@intuit.com

• fix go lint error

Signed-off-by: May Zhang may_zhang@intuit.com

---

Signed-off-by: May Zhang may_zhang@intuit.com

[codecov]

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (394211c) 48.41% compared to head (8a030c2) 48.40%.

Additional details and impacted files

@@               Coverage Diff               @@
##           release-2.6   #16162      +/-   ##
===============================================
- Coverage        48.41%   48.40%   -0.01%     
===============================================
  Files              248      248              
  Lines            42273    42278       +5     
===============================================
  Hits             20465    20465              
- Misses           19740    19745       +5     
  Partials          2068     2068              

Files	Coverage Δ
notification_controller/controller/controller.go	1.42% <0.00%> (-0.06%)	⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[crenshaw-dev]

Superseded