Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI check to ensure generated artifacts are up to date #103

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Add CI check to ensure generated artifacts are up to date #103

merged 2 commits into from
Jan 8, 2025
+68 −0

Conversation

jgwest
Copy link
Member

@jgwest jgwest commented Jan 7, 2025 •
edited
Loading

What does this PR do / why we need it:

  • Add a GitHub action to verify that bundle, generated artifacts, and manifests, are all up to date.
    • Based on similar code used by sibling operator (argocd-operator) in argoproj-labs
  • Ran make bundle to ensure action passes

jgwest added 2 commits January 7, 2025 10:55
@jgwest
Add CI check to ensure generated artifacts are up to date
f8e8b96 
Signed-off-by: Jonathan West <jonwest@redhat.com>
@jgwest
Regenerate bundle to include HA fields
83c970d 
Signed-off-by: Jonathan West <jonwest@redhat.com>
chetan-rns
chetan-rns approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@chetan-rns chetan-rns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jgwest
Copy link
Member Author

jgwest commented Jan 8, 2025

Thanks @chetan-rns!

@jgwest jgwest merged commit b4635b5 into argoproj-labs:main Jan 8, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chetan-rns chetan-rns chetan-rns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgwest @chetan-rns