-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] Support multicall v2 #308
Conversation
@tungnguyen20 Thanks for the PR! Please address the linting issue by running |
@DarthMike I just run the script and add test cases. Please help me continue. |
Some tests will fail (see #311). But we can run anyway for now |
Yeah I see :D |
@tungnguyen20 You can merge |
I merged the develop branch. Please help me merge this pull request. Thank you. |
@tungnguyen20 strangely this PR is now failing in other tests even though there's nothing changed that would affect it. |
Hm I don't understand why, but pulled the changes manually to see if it changes will work in CI |
Hmm. Don't know why. It passed 😂 |
I think I will close this PR and reopen a new one which is checked out from latest develop |
@tungnguyen20 you can update from latest develop, I found out why (040ad81) |
@DarthMike Yah I updated. Hope it will work 😁 |
The multicall v2 supported contracts can be found here