Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Account create/import APIs #282

Merged
merged 3 commits into from
Nov 28, 2022
Merged

Refactor Account create/import APIs #282

merged 3 commits into from
Nov 28, 2022

Conversation

DarthMike
Copy link
Member

@DarthMike DarthMike commented Nov 28, 2022 •
edited
Loading

To avoid conflicts and be more explicit #263

dioKaratzas
dioKaratzas approved these changes Nov 28, 2022
View reviewed changes
Copy link
Collaborator

@dioKaratzas dioKaratzas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DarthMike DarthMike merged commit 02e92b9 into develop Nov 28, 2022
@DarthMike DarthMike deleted the issue/account-key-storage-apis branch November 28, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dioKaratzas dioKaratzas dioKaratzas approved these changes

@mluisbrown mluisbrown mluisbrown approved these changes

@dmcrodrigues dmcrodrigues Awaiting requested review from dmcrodrigues

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DarthMike @mluisbrown @dioKaratzas