Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Custom Typed Array #279

Merged
merged 2 commits into from
Nov 28, 2022
Merged

Support Custom Typed Array #279

merged 2 commits into from
Nov 28, 2022

Conversation

joshuajiangdev
Copy link
Contributor

Context: #277

Adding support of custom typed array in signableHash. Cross verified new unit test cases with @metamask/eth-sig-util.

Tests:

  1. All unit tests in EthereumAccount_SignTypedTests

@joshuajiangdev
Copy link
Contributor Author

Hmmm, seems the unexpected failures are not from the unit tests I modified

Test Suite 'EthereumWebSocketClientTests' failed at 2022-11-16 15:14:59.359.
	 Executed 33 tests, with 35 failures (3 unexpected) in 5.265 (5.267) seconds

Any suggestion here?

dioKaratzas
dioKaratzas approved these changes Nov 16, 2022
View reviewed changes
Copy link
Collaborator

@dioKaratzas dioKaratzas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joshuajiangdev
Copy link
Contributor Author

joshuajiangdev commented Nov 16, 2022 •
edited
Loading

Hmmmm 1 workflow awaiting approval has been stucked for 1 day. How to resolve this?

First-time contributors need a maintainer to approve running workflows. Could I get approve to run the workflows?

@joshuajiangdev
Copy link
Contributor Author

in macos workflow, I'm seeing

Test Suite 'EthereumWebSocketClientTests' failed at 2022-11-18 08:45:31.549.
	 Executed 33 tests, with 35 failures (3 unexpected) in 4.931 (4.933) seconds

in linux workflow, I'm seeing

Test Suite 'All tests' failed at 2022-11-18 09:10:51.236
	 Executed 307 tests, with 111 failures (0 unexpected) in 1634.268 (1634.268) seconds
Error: Process completed with exit code 1.

Two questions here:

  1. Linux workflow seems do not have unexpected errors, but it still shows blocked/failed?
  2. The macos workflow seems also have unexpected fails without my change eg. develop branch.

If both failures are expected, how could I land with two workflows to be in the failure state?

@DarthMike
Copy link
Member

@joshuajiangdev We need to migrate to Goerli for tests to pass. Will take this task this week and we can update your PR with that changes so tests pass. Will let you know about progress (#234)

@DarthMike
Copy link
Member

@joshuajiangdev #281 should fix the tests

@DarthMike DarthMike merged commit 72db1e5 into argentlabs:develop Nov 28, 2022
thantthet pushed a commit to thantthet/web3.swift that referenced this pull request Mar 4, 2023
@DarthMike
Merge pull request argentlabs#279 from joshuajiangdev/custom-typed-array
9abfee9 
Support Custom Typed Array
# Conflicts:
#	web3sTests/Account/EthereumAccount+SignTypedTests.swift
#	web3swift/src/Account/TypedData.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dioKaratzas dioKaratzas dioKaratzas approved these changes

@DarthMike DarthMike DarthMike approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshuajiangdev @DarthMike @dioKaratzas