Sign-In with Ethereum + ERC1271 #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @rkreutz for the PR. Will take a bit to review as need to read EIP and a bit loaded with other work this week. But definitely good addition to library! |
|
Please check ERC20Tests.swift line 115 about how to make the newly added tests to be tested with |
|
@dnKaratzas added the tests there |
I know but need to rename the corresponding class names from |
…reutz/web3.swift into feature/sign-in-with-ethereum
|
@dnKaratzas done |
DarthMike
reviewed
Jun 28, 2022
| /// - Returns: a `Bool` indicating if the pair message-signature is verified (whether or not the signature came from the address in the message) | ||
| /// - Throws: `SiweVerifier.Error` if message is not verifiable; | ||
| /// might throw `KeyUtilError` in case recovering the address that signed the message fails | ||
| open func verify(message: SiweMessage, against signature: String) async throws -> Bool { |
There was a problem hiding this comment.
I think this should be public not open?
|
@DarthMike I believe this got forgotten at some point? 😄 |
DarthMike
approved these changes
Jul 18, 2022
|
Thanks @rkreutz, merged |
|
Hey guys, any plans on making a new release to include this one? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
This PR adds some structs/classes around Sign-In with Ethereum (EIP-4361) which is a new standard for trustless sign-ins. This was based on the TypeScript implementation of the same feature by the people behind the proposal.
As part of the implementation, I also added ERC-1271 support. To test it I've deployed a couple contracts to Rinkeby, repo is here.
I've added tests and made sure they are also running fine on Linux (since this will be specially useful for Server Side).
Cheers