-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Format #244
Code Format #244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, but it would be best at this point to update Readme.md
'Contributors' section to explain what needs to be run to abide to code formatting. Maybe add a format.sh
script so it's easy to call
Also, better to modify CI to run formatter tool to ensure there's no changes needed before merging |
Opened an issue for that! |
@dnKaratzas which tool did you use? |
Swiftlint default rules SwiftFormat I made a configuration and changed some rules I don't like. |
@dnKaratzas We'll need to add the rules file to the repo then ( |
We will! You could just merge the code format PR and we will work that on the issue I opened |
Cool, looks good |
No description provided.