Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Format #244

Merged
merged 2 commits into from
Jun 21, 2022
Merged

Code Format #244

merged 2 commits into from
Jun 21, 2022

Conversation

dioKaratzas
Copy link
Collaborator

No description provided.

@dioKaratzas dioKaratzas requested a review from DarthMike June 18, 2022 09:30
Copy link
Member

@DarthMike DarthMike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but it would be best at this point to update Readme.md 'Contributors' section to explain what needs to be run to abide to code formatting. Maybe add a format.sh script so it's easy to call

@DarthMike
Copy link
Member

Also, better to modify CI to run formatter tool to ensure there's no changes needed before merging

@dioKaratzas
Copy link
Collaborator Author

Also, better to modify CI to run formatter tool to ensure there's no changes needed before merging

Opened an issue for that!

@dioKaratzas dioKaratzas reopened this Jun 20, 2022
@DarthMike
Copy link
Member

@dnKaratzas which tool did you use?
swiftlint + swiftFormat with default config?

@dioKaratzas
Copy link
Collaborator Author

@dnKaratzas which tool did you use?

swiftlint + swiftFormat with default config?

Swiftlint default rules SwiftFormat I made a configuration and changed some rules I don't like.

@DarthMike
Copy link
Member

Swiftlint default rules SwiftFormat I made a configuration and changed some rules I don't like.

@dnKaratzas We'll need to add the rules file to the repo then (.swiftformat file)

@dioKaratzas
Copy link
Collaborator Author

We will! You could just merge the code format PR and we will work that on the issue I opened

@DarthMike
Copy link
Member

Cool, looks good

@DarthMike DarthMike merged commit abc0ba2 into argentlabs:develop Jun 21, 2022
@dioKaratzas dioKaratzas deleted the develop branch June 22, 2022 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants