Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: secp256k1 error #236

Merged
merged 1 commit into from
Jun 15, 2022
Merged

fix: secp256k1 error #236

merged 1 commit into from
Jun 15, 2022

Conversation

sirily11
Copy link
Contributor

@sirily11 sirily11 commented Jun 15, 2022 •
edited
Loading

Change secp256k1 package to a maintained package.

Original secp256k1 will throw error like below
Screen Shot 2022-06-15 at 2 43 50 AM

@dioKaratzas dioKaratzas self-requested a review June 15, 2022 07:38
@dioKaratzas dioKaratzas linked an issue Jun 15, 2022 that may be closed by this pull request
Secp dependency warnings in Xcode 13 #215
Closed
dioKaratzas
dioKaratzas reviewed Jun 15, 2022
View reviewed changes
Copy link
Collaborator

@dioKaratzas dioKaratzas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

dioKaratzas
dioKaratzas approved these changes Jun 15, 2022
View reviewed changes
Copy link
Collaborator

@dioKaratzas dioKaratzas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sirily11

@dioKaratzas dioKaratzas merged commit f9466f0 into argentlabs:develop Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dioKaratzas dioKaratzas dioKaratzas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Secp dependency warnings in Xcode 13
2 participants
@sirily11 @dioKaratzas