Remove unused account in eth_estimateGas #233
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good afternoon team, I'm using your library to build an app with web3. Thank you for your work, it has been really helpful. I would like to propose a small improvement.
While building my model I have found that EthereumClient function eth_estimateGas does not use the account parameter and would be good to remove it.
I have a model Token where I inject contract address and
EthereumClient
for the read functions. For the write functions I want the model to return a transaction withGasPrice
andGasLimit
calculated. Having the account as a parameter ofeth_estimateGas
, forces me to inject the account which is not used and is coupled to it.I have maintained signature of the deprecated method.