[ADD] Offchain Read support (EIP-3668) for eth_call and ENS resolution #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarthMike
commented
May 17, 2022
DarthMike
commented
May 17, 2022
Comment on lines
-200
to
+27
| #if compiler(>=5.5) && canImport(_Concurrency) | ||
|
|
||
| @available(macOS 10.15, iOS 13, watchOS 6, tvOS 13, *) | ||
| extension ENSTests { | ||
| func testGivenRopstenRegistry_WhenExistingDomainName_ResolvesOwnerAddressCorrectly_Async() async { | ||
| func testGivenRopstenRegistry_WhenExistingDomainName_ResolvesOwnerAddressCorrectly() async { |
There was a problem hiding this comment.
Default tests now using async/await
DarthMike
commented
May 17, 2022
| import XCTest | ||
| import BigInt | ||
|
|
||
| struct DummyOffchainENSResolve: ABIFunction { |
There was a problem hiding this comment.
Our own deployed contract to test revert responses
DarthMike
commented
May 17, 2022
| } | ||
| } | ||
|
|
||
| enum EthersTestContract { |
There was a problem hiding this comment.
Ethers contract which they set up for their tests, reusing those. ethers-io/ethers.js#2478
fd92f82 to
008332b
Compare
This was referenced May 18, 2022
mluisbrown
approved these changes
May 18, 2022
dmcrodrigues
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for offchain read in
eth_call, and more specifically add support for offchain ENS resolution.An example to resolve is:
offchainexample.eth(both in ropsten and mainnet)See
https://eips.ethereum.org/EIPS/eip-3668
There's another bit of related but not the same work, but will address this here : #205