feat(preserveViewMode): allow preserveViewMode to reset mode onFocus #36
Conversation
src/inputs/DateTimeInput.js
Outdated
| @@ -106,6 +106,7 @@ class DateTimeInput extends BaseInput { | |||
| initializeWith: getInitializer({ initialDate, dateFormat: dateTimeFormat, dateParams: this.getDateParams() }), | |||
| value: parseValue(chooseValue(value, initialDate), dateTimeFormat), | |||
| disable: parseArrayOrValue(disable), | |||
| preserveViewMode: true, | |||
There was a problem hiding this comment.
This is unnecessary to provide preserveViewMode to picker (picker knows nothing about mode).
There was a problem hiding this comment.
right, this would be the prop on the component that would allow the developer to specify whether the onFocus action is the initial view mode state (preserveViewMode: false) or the last view mode (preserveViewMode: true)
There was a problem hiding this comment.
- remove unnecessary prop from
pickerProps; - add
preserveViewMode: trueinDateTimeInput.defaultProps
I think the same should work for DateInput component. And as I see there is no need to add this functionality to TimeInput because it handles mode switching already. That's all, we need to implement preserveViewMode prop only on DateTimeInput and DateInput.
|
Ok, sounds good. I'll get those changes in, fix any tests and update this PR when ready. |
|
Last 2 commits should add everything. It's passing tests and functionally works great. Let me know if there are any other changes. |
README.md
Outdated
| @@ -64,7 +64,8 @@ class DateTimeForm extends React.Component { | |||
| placeholder="Date Time" | |||
| value={this.state.dateTime} | |||
| iconPosition="left" | |||
| onChange={this.handleChange} /> | |||
| onChange={this.handleChange} | |||
| preserveViewMode={true} /> | |||
There was a problem hiding this comment.
This is redundant because component has preserveViewMode: true in default props.
|
Fixed. |
Addresses problem/requirement stated in issue #35:
By setting
preserveViewMode:<Bool>onDateTimeinput tofalse,focusevent of the input will return the user to thestartModeeach time they click in the field, allowing for users to more easily repeat the selection process.