Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xdrv_04_light.ino #5761

Closed
wants to merge 1 commit into from
Closed

Update xdrv_04_light.ino #5761

wants to merge 1 commit into from

Conversation

blakadder
Copy link
Collaborator

@blakadder blakadder commented May 7, 2019

CW and WW channels were wrong in the comments. Fixed it

Description:

Related issue (if applicable): fixes #

Checklist:

  • The pull request is done against the latest dev branch
  • Only relevant files were touched (Also remember to update changelog.ino file)
  • Only one feature/fix was added per PR.
  • The code change is tested and works.
  • The code change pass travis tests. Your PR cannot be merged unless tests pass
  • I accept the CLA.

CW and WW channels were wrong in the comments. Fixed it
@s-hadinger
Copy link
Collaborator

It's basically a question of convention whether it should be Cold/Warm or Warm/Cold.

But your're right, code and comments are inconsistent.

I tested agains 6.5.0.0 and I realized thet I completely inverted Cold/Warm compared to previous versions. Actually, it's not the comment that is wrong, it's the code.

I will submit a PR to get back to RGBCW (6.5.0.0) instead of RGBWC (6.5.0.9).

@arendst
Copy link
Owner

arendst commented May 8, 2019

@s-hadinger from my offline position I thought so too. So yes pls adjust the code for legacy reasons.

@s-hadinger
Copy link
Collaborator

PR #5766 submitted. It should supersede this PR.

@blakadder
Copy link
Collaborator Author

Closing this since its obsoleted

@blakadder blakadder closed this May 8, 2019
@blakadder blakadder deleted the blakadder-patch-2 branch May 8, 2019 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants