Fix package.json cpu for node-linux-ppc64le #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node.js defines `process.arch` as `ppc64` for both obsolete BE and current LE systems. This currently prevents node-linux-ppc64le from being installable:
$ npm i node-linux-ppc64le
npm ERR! code EBADPLATFORM
npm ERR! notsup Unsupported platform for node-linux-ppc64le@19.1.0: wanted {"os":"linux","arch":"ppc64le"} (current: {"os":"linux","arch":"ppc64"})
npm ERR! notsup Valid OS: linux
npm ERR! notsup Valid Arch: ppc64le
npm ERR! notsup Actual OS: linux
npm ERR! notsup Actual Arch: ppc64
|
hi @aredridel - could someone review/merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node.js defines
process.archasppc64for both obsolete BE and current LE systems. This currently prevents node-linux-ppc64le from being installable, e.g.:A combination of this (with a rebuild of all supported versions) and aredridel/node-bin-setup#5 is needed to fix
npm install nodeon Power LE.