-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Serial Monitor Performances #524
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* wip tests * test monitor utils
AlbyIanna
approved these changes
Oct 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
fstasi
added a commit
that referenced
this pull request
Oct 6, 2021
Co-authored-by: Alberto Iannaccone <a.iannaccone@arduino.cc>
per1234
added
topic: code
Related to content of the project itself
topic: serial monitor
Related to the Serial Monitor
type: enhancement
Proposed improvement
labels
Oct 20, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
topic: code
Related to content of the project itself
topic: serial monitor
Related to the Serial Monitor
type: enhancement
Proposed improvement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Serial monitor is affected by performance issues: basically it's not able to keep up with the grpc messages arriving from the CLI when a decent amount of message (>100/sec) is being sent from the board.
There are a number of reasons causing this undesirable effect:
How
A new architecture for the communication has been designed:
How to test
Serial.print
orSerial.println
and use nodelay
in order to have a high throughput of data flowing from the boardRelated issues
fixes #391, fixes #79, fixes #519