Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: warn user when IDE cannot save the sketch #2082

Merged
merged 1 commit into from
Jun 9, 2023
Merged

fix: warn user when IDE cannot save the sketch #2082

merged 1 commit into from
Jun 9, 2023

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented May 30, 2023 •
edited
Loading

## Depends on #2080 ✅

Motivation

IDE2 must warn the users to manually save the sketch content when IDE cannot do it due to a crashed backend process.

Change description

Check the socket.connected status when calculating the nature of the connectivity problem in the frontend.

Steps to verify: Please see #2081

Other information

Closes #2081

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels May 30, 2023
@kittaakos kittaakos requested review from AlbyIanna and per1234 May 30, 2023 13:08
@kittaakos kittaakos self-assigned this May 30, 2023
Base automatically changed from #2079 to main June 8, 2023 06:53
per1234
per1234 approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified this fixes #2081

Thanks Akos!

fix: warn user when IDE cannot save the sketch
a2a14af 
Happens when the IDE2 backend process crashes, and the communication
drops between the client and the server.

Closes #2081

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos merged commit 8f8b46f into main Jun 9, 2023
@kittaakos kittaakos deleted the #2081 branch June 9, 2023 10:11
@per1234 per1234 mentioned this pull request Jun 17, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

@AlbyIanna AlbyIanna Awaiting requested review from AlbyIanna

Assignees

@kittaakos kittaakos

Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IDE2 frontend cannot save the sketch content when the IDE2 backend process crashed
2 participants
@kittaakos @per1234