Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard control for Serial Monitor send was changed #572

Closed
per1234 opened this issue Oct 23, 2021 · 6 comments · Fixed by #1402
Closed

Keyboard control for Serial Monitor send was changed #572

per1234 opened this issue Oct 23, 2021 · 6 comments · Fixed by #1402
Assignees
@kittaakos @fstasi @AlbyIanna
Labels
conclusion: resolved Issue was resolved criticality: medium Of moderate impact phase: implementation Work is in the implementation phase priority: high Resolution is a high priority topic: code Related to content of the project itself topic: serial monitor Related to the Serial Monitor type: imperfection Perceived defect in any part of project

Comments

@per1234
Copy link
Contributor

per1234 commented Oct 23, 2021 •
edited
Loading

Describe the bug

🐛 The keyboard control for sending data from Serial Monitor was changed from Enter in the classic Arduino IDE to the unintuitive and less convenient Ctrl+Enter in Arduino IDE 2.x

The first time I tried to send data via Serial Monitor, I jumped straight to typing into the input field without bothering to look at the gray text, then spent some time repeatedly pressing "Enter" without any result and hunting around for that "Send" button.

To Reproduce

  1. Connect any Arduino board that presents a serial port to your computer.
  2. Select Tools > Serial Monito from the Arduino IDE menus.
  3. Type some text in the Serial Monitor input field.
  4. Press Enter.
    🐛 Nothing happens.

Expected behavior

Pressing the Enter key while the Serial Monitor input field is selected causes the data to be sent if any is present.

Screenshots

In the Java IDE's Serial Monitor, sending data is done by typing into the input field and then either pressing "Enter" or clicking the "Send" button:

Unknown.png

In Arduino IDE 2.x, there is a message that explains the unintuitive Ctrl+Enter system to the user:

Unknown-1.png

but that message disappears as soon as you start typing (as it must). The user will expect the field to work in an intuitive manner and not bother to read the text, then once the find it is not working as expected, the text won't be there to guide them:

Unknown-2.png

Desktop

  • OS: Windows 10
  • Version: 2.0.0-beta.12-nightly.20211021
    Date: 2021-10-21T03:03:16.691Z
    CLI Version: 0.19.1 alpha [718bbbf2]

Additional context

The loss of the Send button (#348) worsens the poor user experience of sending data via Serial Monitor via Arduino IDE 2.x.

Reported at:
@per1234 per1234 added phase: implementation Work is in the implementation phase priority: medium Resolution is a medium priority topic: code Related to content of the project itself topic: serial monitor Related to the Serial Monitor type: imperfection Perceived defect in any part of project labels Oct 23, 2021
@rsora rsora added criticality: medium Of moderate impact and removed priority: medium Resolution is a medium priority labels Nov 2, 2021
@ubidefeo ubidefeo added the priority: high Resolution is a high priority label Jan 25, 2022
@per1234 per1234 mentioned this issue Feb 5, 2022
Closed
This was referenced Jun 10, 2022
Merged
Closed
@tigoe
Copy link
Member

tigoe commented Jun 13, 2022 •
edited
Loading

Pressing enter in a text field to enter the text isn't just a pattern of the old Serial Monitor, it's a well-established GUI pattern across most operating systems.

Steps to find the problem, after @per1234's calling this issue to my attention:

  1. Open File -> Examples -> Communications -> Physical Pixel
  2. Change ledPin to LED_BUILTIN
  3. open serial monitor
  4. Being aware that I needed to hit the command key, accidentally hit command-H

Try it and see what happens.

What is the reason for this change? The enter key doesn't appear to have any other function in this context by itself, so I see no reason why it can't do what it's supposed to. If we're trying to support non-printables like \n, then we should find another way, perhaps with a regex toggle like VS Code does. It seems like an edge case, frankly.

@PaulStoffregen
Copy link

PaulStoffregen commented Jun 17, 2022 •
edited
Loading

Who could I bribe to make this a rc8 milestone?

I know it probably seems "trivial", but seriously, this is a huge usability problem. Hopefully with rc8 we can reach a much larger number of users for testing & feedback, now that so much other stuff is working well. Everyone is going to hit this problem.

@per1234 per1234 mentioned this issue Jun 28, 2022
Closed
@tigoe
Copy link
Member

tigoe commented Jun 29, 2022

Just tested this on 2.0.0-rc8 and the nightly build from today, 06292022. The problem still persists.

@per1234 per1234 mentioned this issue Aug 3, 2022
Closed
3 tasks
@philipmcgaw-cpi
Copy link

Issue still persists.

@kittaakos kittaakos self-assigned this Sep 5, 2022
kittaakos pushed a commit that referenced this issue Sep 5, 2022
Can send message to the monitor with Enter.
f52143f 
Removed the required `Ctrl/Cmd` modifier.

Closes #572

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos mentioned this issue Sep 5, 2022
Merged
4 tasks
kittaakos pushed a commit that referenced this issue Sep 14, 2022
@kittaakos
Can send message to the monitor with Enter.
5f82577 
Removed the required `Ctrl/Cmd` modifier.

Closes #572

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@per1234 per1234 added the conclusion: resolved Issue was resolved label Sep 14, 2022
@PJLC
Copy link

PJLC commented Oct 19, 2022

what a mess with arduino V2.0 serial monitor...
It does not accept Enter key, only Ctrl+Enter to send. How do I change the serial monitor to behave exactly as V1.8?
Help would be very appreciated.

@per1234
Copy link
Contributor Author

per1234 commented Oct 19, 2022

Hi @PJLC. If you look carefully, you will see this bug has already been resolved. It was fixed after the 2.0.0 release, so you will find that Ctrl+Enter is still required when you use that version, but the fix is available from the nightly build, so simply use the nightly if this bothers you.

The nightly build download links are listed here:

https://www.arduino.cc/en/software#nightly-builds

If you have other questions about using the Arduino IDE, please post over on the forum:

https://forum.arduino.cc/c/software/arduino-ide-2-0/93

We'll be happy to help you out over there.

@arduino arduino locked as resolved and limited conversation to collaborators Oct 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kittaakos kittaakos

@fstasi fstasi

@AlbyIanna AlbyIanna

Labels
conclusion: resolved Issue was resolved criticality: medium Of moderate impact phase: implementation Work is in the implementation phase priority: high Resolution is a high priority topic: code Related to content of the project itself topic: serial monitor Related to the Serial Monitor type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#572 Can send message to the monitor with Enter arduino/arduino-ide
10 participants
@tigoe @PaulStoffregen @kittaakos @fstasi @ubidefeo @PJLC @AlbyIanna @per1234 @rsora @philipmcgaw-cpi