Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ws): add ws endpoint #1015

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat(ws): add ws endpoint #1015

wants to merge 3 commits into from

Conversation

dido18
Copy link
Contributor

@dido18 dido18 commented Jan 28, 2025

Motivation

Currently, the agent seems to be using https://github.com/googollee/go-socket.io which (besides being archived) implements the v1.4 of Socket.IO client (it looks like it's compatible with 2.x as well for some reason).

Now, the current state of the JS library for communicating with the agent is pretty bad from multiple points of view (from a lack of documentation to a lack of types, to an annoying number of bugs, issues and gotchas in the current implementation).

Now, the issue is that in order to communicate with the agent we're forced to use the v2 implementation (again, because server v2 seems to be working somehow, otherwise we'd have to go v1.x - see https://socket.io/docs/v4/client-installation/#version-compatibility), and that means our hands are tied in various places:

  • What kind of change does this PR introduce?

Feature

  • What is the current behavior?
  • What is the new behavior?
  • Does this PR introduce a breaking change?
  • Other information:

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 59 lines in your changes missing coverage. Please review.

Project coverage is 19.78%. Comparing base (1b94ccc) to head (3e691cd).

Files with missing lines Patch % Lines
main.go 0.00% 59 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1015      +/-   ##
==========================================
- Coverage   20.14%   19.78%   -0.36%     
==========================================
  Files          42       42              
  Lines        3222     3280      +58     
==========================================
  Hits          649      649              
- Misses       2488     2546      +58     
  Partials       85       85              
Flag Coverage Δ
unit 19.78% <0.00%> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants