-
-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add archive command to zip a sketch and its files #931
Conversation
4bfe576
to
19b2f98
Compare
f6d0094
to
3fb2fab
Compare
3fb2fab
to
5dbeb05
Compare
Links check is failing again because of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made some suggestions to slightly simplify here and there.
I'm wondering if the case:
arduino-cli archive . /path/to/some/dir/name
should automatically infer that we mean /path/to/some/dir/name.zip
when the name
folder doesn't exists. Personally, if I don't specify explicitly .zip
I would expect a /path/to/some/dir/name: directory does not exists
, but I'll leave to @ubidefeo the last word on this.
Nice work BTW, especially on the tests! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
d30501d
to
222b454
Compare
222b454
to
7771404
Compare
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
New CLI command and new gRPC interface.
User can't create an archive of a Sketch from the CLI.
gRPC consumer doesn't have an interface to archive a Sketch.
User can create a
zip
file containing all files from a Sketch,build
directory is only included if explicitly specified with the--include-build-dir
flag.Some possible examples on how to call the command from the CLI:
No.
None.
See how to contribute