Update SDU library to support Arduino nano 33 iot board #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for nano 33 iot
…e-samd/upload/master/libraries/SDU/src/boot directory
|
Reason why checks failed is due to one library as far as i can tell. Same reason prior pull request below mine failed Here is what failed: In file included from /home/runner/.arduino15/packages/arduino/hardware/samd/1.8.11/cores/arduino/api/ArduinoAPI.h:31:0, Error during build: exit status 1 |
|
Hi @winner10920. Thanks for your PR. You are correct in your finding that the CI failure is unrelated to the changes you propose here. Please disregard that failed compilation. You can learn more about it here: #616 |
|
|
|
Memory usage change @ 6e8bb3b
Click for full report table
|
1 similar comment
|
Memory usage change @ 6e8bb3b
Click for full report table
|
|
@winner10920 I tested this and doesn't work for me on nano 33 iot using the SD card with the right UPDATE.bin file |
@agdl |
|
Ok, I made it work, anyway I will push a commit that makes the SD pin configurable by the sketch so that if you have to change it you don't need to recompile SDUBoot everytime |
|
@winner10920 for now I changed a bit the code to make it backward compatible with the SDU legacy. Would you mind to import these changes in your PR? cc @facchinm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the SDU Library to support the Arduino nano 33 iot as well as adds a readme to add support for more boards. Binary file for the new board compiled on IDE 1.8.13, this update makes the SDU library take up more flash space (8192 bytes) to allow for a difference in compile size. That is considerably larger than the original size (16384->25476) however considering the memory of the samd is 262144 bytes large that's only a 3% increase which is worth it I believe