PE-7109: feat(cli) add custom Arweave tags support #216
Conversation
- Add tags option to CLI for specifying custom Arweave tags - Implement tag parsing utility for CLI input format (name/value pairs) - Update upload file options to include tags parameter - Add types for tag support in UploadFileOptions - Forward parsed tags to upload methods Example usage: turbo upload-file --tags Content-Type image/png App-Name MyApp
|
Seems like rogue file |
CHANGELOG.md
Outdated
There was a problem hiding this comment.
Might need to rebase if this is here?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #216 +/- ##
=======================================
Coverage 93.40% 93.40%
=======================================
Files 25 25
Lines 3562 3562
Branches 161 161
=======================================
Hits 3327 3327
Misses 235 235 ☔ View full report in Codecov by Sentry. |
src/cli/utils.ts
Outdated
|
|
||
| const tags: { name: string; value: string }[] = []; | ||
|
|
||
| for (let i = 0; i < tagsArr.length; i += 2) { |
There was a problem hiding this comment.
No need to change this but another way to do this in fewer lines of code:
while(a.length) {
const tag = { name: tagsArr.shift(), value: tagsArr.shift() };
if (tag.name === undefined || tag.value === undefined) {
throw new Error(
'Invalid tag format. Each tag must have both a name and value.',
);
}
tags.push(tag);
}
While loops can be risky but the risks are pretty contained here.
There was a problem hiding this comment.
QUICK NOTE: Empty strings are falsey in js. Double check on the validity of empty tag names and values.
| tags: { | ||
| description: | ||
| 'An array of additional tags for the write action, in "--tags name1 value1 name2 value2" format', | ||
| alias: '--tags <tags...>', |
There was a problem hiding this comment.
Is this the correct use of alias? Seems like no alias is being assigned.
There was a problem hiding this comment.
yeah it looks good. We could include a short code alias here but need to check if they conflict with other short codes
Co-authored-by: Derek Sonnenberg <derek@ardrive.io>
- Add tags option to upload commands - Integrate tag support in uploadFile and uploadFolder commands - Add tags to UploadOptions interface
…tent-type' of github.com:ardriveapp/turbo-sdk into PE-7109-upload-file-turbo-cli-allow-custom-tags-and-content-type
…tags-and-content-type
|
🎉 This PR is included in version 1.22.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.22.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Example usage: