Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(arweave): modify import of Arweave in ArweaveToken #200

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

dtfiedler
Copy link
Collaborator

Temporary patch for issues related to using .init() in web environments

Temporary patch for issues related to using `.init()` in web environments
@dtfiedler dtfiedler requested a review from a team as a code owner November 4, 2024 15:36
@@ -54,7 +54,7 @@ export class ArweaveToken implements TokenTools {

this.arweave =
arweave ??
Arweave.init({
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fedellen - the only SDK change, i think it's just how bundlers tree shake the arweave import here and they use node by default - causing the default.init() not to exist in web projects. more to understand there but worked with my local example so will ask others to test.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.60%. Comparing base (b2acf6a) to head (b934677).
Report is 12 commits behind head on alpha.

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha     #200   +/-   ##
=======================================
  Coverage   93.60%   93.60%           
=======================================
  Files          25       25           
  Lines        3485     3486    +1     
  Branches      159      159           
=======================================
+ Hits         3262     3263    +1     
  Misses        223      223           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dtfiedler dtfiedler merged commit 039c914 into alpha Nov 4, 2024
9 checks passed
@dtfiedler dtfiedler deleted the arweave-fix branch November 4, 2024 15:41
@dtfiedler
Copy link
Collaborator Author

🎉 This PR is included in version 1.20.0-alpha.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dtfiedler
Copy link
Collaborator Author

🎉 This PR is included in version 1.20.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants