Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pol): add support for matic/pol crypto fund PE-6722 #176

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

fedellen
Copy link
Collaborator

> node lib/esm/cli/cli.js crypto-fund -v 0.0000100 --wallet-file ../wallets/eth.pk.0x02f40b84CdDe657245049476E1E01DDffde6a21c.txt --dev --token pol
✔ 
Transaction details:

  Amount: 0.0000100 pol
  Target: 0x9B13eb5096264B12532b8C648Eba4A662b4078ce
  Credits received: 0.000000158685
  Credit recipient: 0x02f40b84CdDe657245049476E1E01DDffde6a21c
  Network fees: (Gas fees apply)

This payment is non-refundable.  Proceed with transaction? … yes
Sent crypto fund transaction: 
 {
  "id": "0xa07007636bc0367d73c8fe562c58e0e035961f4262603cc3c89815ad9fd06293",
  "quantity": "10000000000000",
  "owner": "0x02f40b84CdDe657245049476E1E01DDffde6a21c",
  "winc": "158685",
  "token": "matic",
  "status": "pending",
  "target": "0x9B13eb5096264B12532b8C648Eba4A662b4078ce"
}

@fedellen fedellen requested a review from a team as a code owner September 13, 2024 18:14
@fedellen fedellen force-pushed the PE-6722-pol-crypto-fund branch from c6ff0b3 to ee523ba Compare September 13, 2024 18:38
@fedellen fedellen requested a review from dtfiedler September 13, 2024 18:45
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 1.15942% with 341 lines in your changes missing coverage. Please review.

Project coverage is 84.79%. Comparing base (8dcdae7) to head (a48d902).

Files with missing lines Patch % Lines
src/cli/commands/topUp.ts 0.00% 99 Missing ⚠️
src/cli/commands/cryptoFund.ts 0.00% 81 Missing ⚠️
src/cli/commands/balance.ts 0.00% 53 Missing ⚠️
src/cli/commands/uploadFolder.ts 0.00% 46 Missing ⚠️
src/cli/commands/uploadFile.ts 0.00% 40 Missing ⚠️
src/cli/commands/index.ts 0.00% 22 Missing ⚠️
Additional details and impacted files
@@                         Coverage Diff                         @@
##           PE-6721-pol-uploads-and-top-ups     #176      +/-   ##
===================================================================
- Coverage                            92.42%   84.79%   -7.63%     
===================================================================
  Files                                   30       31       +1     
  Lines                                 3816     3421     -395     
  Branches                               170      140      -30     
===================================================================
- Hits                                  3527     2901     -626     
- Misses                                 289      520     +231     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dtfiedler dtfiedler self-requested a review September 13, 2024 18:50
@fedellen fedellen merged commit 032db83 into PE-6721-pol-uploads-and-top-ups Sep 13, 2024
7 checks passed
@fedellen fedellen deleted the PE-6722-pol-crypto-fund branch September 13, 2024 18:51
@dtfiedler
Copy link
Collaborator

🎉 This PR is included in version 1.17.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dtfiedler
Copy link
Collaborator

🎉 This PR is included in version 1.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants