Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PE-6732: crypto fund confirmation prompt #169

Merged
merged 4 commits into from
Sep 12, 2024
Merged

Conversation

fedellen
Copy link
Collaborator

this PR:

  • adds confirmation prompt by default for crypto-fund command
  • adds --tx-id parameter for using crypto-fund command on existing payment tx

@fedellen fedellen requested a review from dtfiedler September 12, 2024 18:38
@fedellen fedellen self-assigned this Sep 12, 2024
@fedellen fedellen requested a review from a team as a code owner September 12, 2024 18:38
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.35%. Comparing base (bc930f4) to head (15aa559).
Report is 15 commits behind head on alpha.

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha     #169   +/-   ##
=======================================
  Coverage   92.35%   92.35%           
=======================================
  Files          30       30           
  Lines        3778     3778           
  Branches      164      164           
=======================================
  Hits         3489     3489           
  Misses        289      289           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fedellen fedellen merged commit 34096d9 into alpha Sep 12, 2024
7 checks passed
@fedellen fedellen deleted the PE-6732-confirmation-prompt branch September 12, 2024 19:03
@dtfiedler
Copy link
Collaborator

🎉 This PR is included in version 1.16.0-alpha.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dtfiedler
Copy link
Collaborator

🎉 This PR is included in version 1.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants